[hermes] Improve integration test determinism#3212
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6067 6067
=======================================
Hits 5573 5573
Misses 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
4a04464 to
070f928
Compare
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
070f928 to
4812973
Compare
Closed
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
4812973 to
4fef336
Compare
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
4fef336 to
fafc743
Compare
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
fafc743 to
8ba6550
Compare
joshlf
changed the title
targettarget/hermes-home
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
8ba6550 to
7820f4e
Compare
joshlf
changed the title
target/hermes-hometarget
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
7820f4e to
2bccf2e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
2bccf2e to
1c5d773
Compare
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
1c5d773 to
ddcb15c
Compare
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
ddcb15c to
d63baea
Compare
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
d63baea to
d65fabf
Compare
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
d65fabf to
5b5489b
Compare
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
5b5489b to
b7974ff
Compare
joshlf
changed the title
target
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
b7974ff to
da78819
Compare
Disable timestamps in `env_logger` output. Support `HERMES_HASH_WITH_REMOVED_PREFIX` which strips a prefix from paths before hashing them (this is set by `tests/integration.rs`). Only forward select environment variables to integration tests, stripping all others. Sanitize the path to the target directory. Sanitize Lake progress indicators by stripping them entirely, as their existence itself is nondeterministic. In dev, install prebuilts in `target`. This allows developers to isolate their development from their use of `cargo hermes verify` globally. It also makes development slightly easier to integrate with Docker, as `cargo run setup`, when run in the container, doesn't try to write to paths that aren't writeable (this is specifically a problem since we re-define the UID of the user in the container in order to match the external UID, making them not root in the container, but thus making them not have write permissions to root's home directory). gherrit-pr-id: Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
joshlf
force-pushed
the
Gzjx2m23qp7ycaxvr2hvvsspjslbysoix
branch
from
da78819 to
fc31802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable timestamps in
env_loggeroutput.Support
HERMES_HASH_WITH_REMOVED_PREFIXwhich strips a prefix frompaths before hashing them (this is set by
tests/integration.rs).Only forward select environment variables to integration tests,
stripping all others.
Sanitize the path to the target directory.
Sanitize Lake progress indicators by stripping them entirely, as their
existence itself is nondeterministic.
In dev, install prebuilts in
target. This allows developers to isolatetheir development from their use of
cargo hermes verifyglobally. Italso makes development slightly easier to integrate with Docker, as
cargo run setup, when run in the container, doesn't try to write topaths that aren't writeable (this is specifically a problem since we
re-define the UID of the user in the container in order to match the
external UID, making them not root in the container, but thus making
them not have write permissions to root's home directory).
Latest Update: v19 — Compare vs v18
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gzjx2m23qp7ycaxvr2hvvsspjslbysoix && git checkout -b pr-Gzjx2m23qp7ycaxvr2hvvsspjslbysoix FETCH_HEADCheckout
git fetch origin refs/heads/Gzjx2m23qp7ycaxvr2hvvsspjslbysoix && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gzjx2m23qp7ycaxvr2hvvsspjslbysoix && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.