[anneal] Remove support for system-wide binary deps#3274
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3274 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 20 20
Lines 6076 6076
=======================================
Hits 5583 5583
Misses 493 493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
G5aykmemfqpvhspa7s5mx5n3ookum45cy
branch
from
dde2b30 to
a767a66
Compare
joshlf
force-pushed
the
G5aykmemfqpvhspa7s5mx5n3ookum45cy
branch
from
a767a66 to
23c4b8d
Compare
Now that we support installing `charon` into our Anneal-managed global toolchain directory, we can remove the fallback to `$PATH` and we no longer need to check that we're using the right version of `charon`. Closes #3263 gherrit-pr-id: G5aykmemfqpvhspa7s5mx5n3ookum45cy
joshlf
force-pushed
the
G5aykmemfqpvhspa7s5mx5n3ookum45cy
branch
from
23c4b8d to
6656c07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we support installing
charoninto our Anneal-managed globaltoolchain directory, we can remove the fallback to
$PATHand we nolonger need to check that we're using the right version of
charon.Closes #3263
Latest Update: v4 — Compare vs v3
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G5aykmemfqpvhspa7s5mx5n3ookum45cy && git checkout -b pr-G5aykmemfqpvhspa7s5mx5n3ookum45cy FETCH_HEADCheckout
git fetch origin refs/heads/G5aykmemfqpvhspa7s5mx5n3ookum45cy && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G5aykmemfqpvhspa7s5mx5n3ookum45cy && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.