[anneal] Use Lean artifact cache; use local-filesystem git dep#3304
Merged
[anneal] Use Lean artifact cache; use local-filesystem git dep#3304
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
joshlf
force-pushed
the
Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr
branch
from
416affa to
0a31816
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3304 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 20 20
Lines 6076 6076
=======================================
Hits 5583 5583
Misses 493 493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr
branch
from
0a31816 to
767958e
Compare
joshlf
force-pushed
the
Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr
branch
from
767958e to
f1402a9
Compare
joshlf
force-pushed
the
Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr
branch
from
f1402a9 to
a402330
Compare
9 tasks
joshlf
force-pushed
the
Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr
branch
from
a402330 to
ed6b041
Compare
- Store build artifacts in a user-global Lean content-addressed artifact
cache, populating it during `setup`.
- Specify the dependency on the Aeneas Lean library as follows:
- During `setup`, initialize the Aeneas Lean library as a git repo
- During `generate`/`verify`, specify the dependency as a git
dependency on a local filesystem path
Prior to this change, we specified the dependency as a non-git
filesystem dep, which had the effect of causing Lean to think it could
mutate the user-global directory, causing races when multiple `anneal`
commands were run in parallel.
Release 0.1.0-alpha.20
gherrit-pr-id: Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr
joshlf
force-pushed
the
Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr
branch
from
ed6b041 to
69e77a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cache, populating it during
setup.setup, initialize the Aeneas Lean library as a git repogenerate/verify, specify the dependency as a gitdependency on a local filesystem path
Prior to this change, we specified the dependency as a non-git
filesystem dep, which had the effect of causing Lean to think it could
mutate the user-global directory, causing races when multiple
annealcommands were run in parallel.
Release 0.1.0-alpha.20
Latest Update: v7 — Compare vs v6
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr && git checkout -b pr-Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr FETCH_HEADCheckout
git fetch origin refs/heads/Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gyo2pqvhru3x4cyrj6bhrnjtx7gamwkfr && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.