[anneal] Cleanup test infrastructure and implement atomic setup#3305
Merged
[anneal] Cleanup test infrastructure and implement atomic setup#3305
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3305 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 20 20
Lines 6076 6076
=======================================
Hits 5583 5583
Misses 493 493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
G4c76oil24wlyjqav3c5s5woakn5rcxpm
branch
from
a71a6d5 to
2fb636c
Compare
joshlf
changed the title
joshlf
force-pushed
the
G4c76oil24wlyjqav3c5s5woakn5rcxpm
branch
from
2fb636c to
9c54d16
Compare
joshlf
force-pushed
the
G4c76oil24wlyjqav3c5s5woakn5rcxpm
branch
from
9c54d16 to
20034af
Compare
joshlf
force-pushed
the
G4c76oil24wlyjqav3c5s5woakn5rcxpm
branch
from
20034af to
7f5cca4
Compare
- Remove obsolete worker pool and smart cache cloning from integration tests - Configure tests to use the shared global Lean artifact cache via `LAKE_CACHE_DIR` - Simplify `src/setup.rs` by assuming only fresh installations: - Remove `verify_tools` and individual binary checksums for Aeneas - Simplify toolchain directory hashing to use the Rust tag - Make installation and Git initialization unconditional - Implement atomic installation in `setup` using a temporary directory and rename - Remove setup-related tests which are less useful now, and will become even less useful than that going forward as we simplify the setup logic Prior to this change, the integration tests relied on a complex worker pool and symlinking infrastructure to isolate tests and share build artifacts. This required large amounts of disk space (e.g., a specific run with ~100 parallel worker threads and caches consumed ~100GB). In this commit, removing the worker pool and cache cloning approach lets us save significant disk space usage during integration test runs. gherrit-pr-id: G4c76oil24wlyjqav3c5s5woakn5rcxpm
joshlf
force-pushed
the
G4c76oil24wlyjqav3c5s5woakn5rcxpm
branch
from
7f5cca4 to
f98458e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests
LAKE_CACHE_DIRsrc/setup.rsby assuming only fresh installations:verify_toolsand individual binary checksums for Aeneassetupusing a temporary directoryand rename
even less useful than that going forward as we simplify the setup
logic
Prior to this change, the integration tests relied on a complex worker
pool and symlinking infrastructure to isolate tests and share build
artifacts. This required large amounts of disk space (e.g., a specific
run with ~100 parallel worker threads and caches consumed ~100GB). In
this commit, removing the worker pool and cache cloning approach lets us
save significant disk space usage during integration test runs.
Latest Update: v6 — Compare vs v5
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G4c76oil24wlyjqav3c5s5woakn5rcxpm && git checkout -b pr-G4c76oil24wlyjqav3c5s5woakn5rcxpm FETCH_HEADCheckout
git fetch origin refs/heads/G4c76oil24wlyjqav3c5s5woakn5rcxpm && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G4c76oil24wlyjqav3c5s5woakn5rcxpm && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.