[anneal] Don't copy Lean build artifacts from ~/.anneal#3344
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3344 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 20 20
Lines 6076 6076
=======================================
Hits 5583 5583
Misses 493 493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gks63dnqyjzxt6s6sgowdaz63rogw5kz3
branch
from
344fa4d to
0f5260e
Compare
joshlf
changed the title
~/.anneal
joshlf
force-pushed
the
Gks63dnqyjzxt6s6sgowdaz63rogw5kz3
branch
from
0f5260e to
d59d607
Compare
Prior to this change, Lake verification relied on recursively copying the entire global precompiled toolchain package directory (~5,000 `.olean` files, ~5GB) into a build directory. This was obviously slow and caused massive disk bloat. In this commit, we instead: - Copy only those files which Lake will attempt to write, and symlink all other files. In practice, this means that only the smallest files are actually copied. (Note: Copying is necessary *at all* because Lake will write to some files in the directories of a package's *dependencies* if those dependencies are filesystem-local. Without copying, this would result in concurrent writes to the user-global `~/.anneal/toolchain` directory.) - Mark the `~/.anneal/toolchain/<toolchain>` directory as recursively read-only to ensure that any attempted writes fail loudly. Release 0.1.0-alpha.22. gherrit-pr-id: Gks63dnqyjzxt6s6sgowdaz63rogw5kz3
joshlf
force-pushed
the
Gks63dnqyjzxt6s6sgowdaz63rogw5kz3
branch
from
d59d607 to
2f1d4df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, Lake verification relied on recursively copying
the entire global precompiled toolchain package directory (~5,000
.oleanfiles, ~5GB) into a build directory. This was obviously slowand caused massive disk bloat.
In this commit, we instead:
all other files. In practice, this means that only the smallest files
are actually copied. (Note: Copying is necessary at all because Lake
will write to some files in the directories of a package's
dependencies if those dependencies are filesystem-local. Without
copying, this would result in concurrent writes to the user-global
~/.anneal/toolchaindirectory.)~/.anneal/toolchain/<toolchain>directory as recursivelyread-only to ensure that any attempted writes fail loudly.
Release 0.1.0-alpha.22.
~/.anneal#3344Latest Update: v4 — Compare vs v3
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gks63dnqyjzxt6s6sgowdaz63rogw5kz3 && git checkout -b pr-Gks63dnqyjzxt6s6sgowdaz63rogw5kz3 FETCH_HEADCheckout
git fetch origin refs/heads/Gks63dnqyjzxt6s6sgowdaz63rogw5kz3 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gks63dnqyjzxt6s6sgowdaz63rogw5kz3 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.