[anneal][v2] Implement out-of-tree dependency chasing for expand command#3405
Open
mdittmer wants to merge 1 commit into
Open
[anneal][v2] Implement out-of-tree dependency chasing for expand command#3405mdittmer wants to merge 1 commit into
mdittmer wants to merge 1 commit into
Conversation
This was referenced May 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gnafivbpqcaatsvsxamgsjcudchscvaae #3405 +/- ##
==================================================================
Coverage 91.84% 91.84%
==================================================================
Files 20 20
Lines 6080 6080
==================================================================
Hits 5584 5584
Misses 496 496 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdittmer
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
17613f2 to
a3d47a3
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
e8af624 to
1c62cfd
Compare
mdittmer
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
a3d47a3 to
e60c407
Compare
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
43a1ef4 to
c7bc335
Compare
mdittmer
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
e60c407 to
56d3125
Compare
Notes about largely unreviewed generated change: - Last test assertion looks dubious. Should probably switch all LLBC test verifications to something that properly parses the LLBC and makes more precise assertions. - Integration and structure requires more thought. It seems that only the scanner "knows" about this behaviour; is it being being plumbed through cmdline args and through run_charon? - New test (and probably other tests) should have their setup procedures overhauled/simplified. In general, I would expect the test to create a fixture, and then be able to pass largely static data to `run_charon()`, but right now it's manually setting up locked roots, etc., etc. gherrit-pr-id: Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
mdittmer
force-pushed
the
Gnafivbpqcaatsvsxamgsjcudchscvaae
branch
from
c7bc335 to
fafcee4
Compare
mdittmer
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
56d3125 to
25f8010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes about largely unreviewed generated change:
Last test assertion looks dubious. Should probably switch all LLBC
test verifications to something that properly parses the LLBC and
makes more precise assertions.
Integration and structure requires more thought. It seems that only
the scanner "knows" about this behaviour; is it being being plumbed
through cmdline args and through run_charon?
New test (and probably other tests) should have their setup procedures
overhauled/simplified. In general, I would expect the test to create
a fixture, and then be able to pass largely static data to
run_charon(), but right now it's manually setting up locked roots,etc., etc.
Latest Update: v5 — Compare vs v4
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3 && git checkout -b pr-Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3 FETCH_HEADCheckout
git fetch origin refs/heads/Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.