Adds new AddRemarketingAction code example#235
Conversation
Change-Id: Id77a16e759dc0d159148fcce2841aeb4cda5c4c9
Change-Id: I2699b47fcf739e77b2312891701486251383e82d
devchas
left a comment
devchas
left a comment
There was a problem hiding this comment.
LGTM with one minor comment.
| try (GoogleAdsServiceClient googleAdsServiceClient = | ||
| googleAdsClient.getLatestVersion().createGoogleAdsServiceClient()) { | ||
| // Issues a search request. | ||
| SearchPagedResponse searchPagedResponse = |
There was a problem hiding this comment.
You do not use a SearchGoogleAdsRequest with page size information for this search request, is it intended?
I am asking because the golden has it.
There was a problem hiding this comment.
Since we're only interested in one row from the result set, I don't see much value in creating a request object or setting the page size, and I think it hinders readability. Would prefer to leave this as-is unless you have strong objections.
| RemarketingAction newRemarketingAction = googleAdsRow.getRemarketingAction(); | ||
| System.out.printf( | ||
| "Remarketing action has ID %d and name '%s'.%n%n", | ||
| newRemarketingAction.getId().getValue(), newRemarketingAction.getName().getValue()); |
There was a problem hiding this comment.
I think it would be more readable with one argument per line as done in other code examples.
There was a problem hiding this comment.
This is the format produced by the Google Java formatter, so would prefer to leave this as-is. Otherwise, any manual edits I make will probably be undone by the next editor of this file.
3 participants
Change-Id: Id77a16e759dc0d159148fcce2841aeb4cda5c4c9