Skip to content

Update dependency versions for consistency#268

Merged
jradcliff merged 2 commits intomasterfrom
depupdates
Apr 2, 2020
Merged

Update dependency versions for consistency#268
jradcliff merged 2 commits intomasterfrom
depupdates

Conversation

@jradcliff
Copy link
Copy Markdown
Member

  • Move to netty-tcnative-boringssl-static version 2.0.26.Final and protobuf version 3.10.0 to match to match target gRPC version 1.25.0.
  • Move more recent versions of auto-value and protoc-jar-maven-plugin.
  • Make log4j dependencies in examples modules have scope of runtime since they are not needed for compilation.

@jradcliff jradcliff requested a review from nwbirnie March 30, 2020 21:20
@jradcliff
Copy link
Copy Markdown
Member Author

Please see the table in the Netty section here for gRPC + Netty version compatibility.

@jradcliff jradcliff requested a review from devchas March 30, 2020 21:23
@jradcliff jradcliff self-assigned this Mar 30, 2020
@jradcliff
Copy link
Copy Markdown
Member Author

Friendly ping for @nwbirnie and @devchas for review

Comment thread google-ads/pom.xml
Copy link
Copy Markdown
Contributor

@devchas devchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending resolution of Nick's comment.

@jradcliff jradcliff requested a review from nwbirnie April 2, 2020 15:10
Comment thread google-ads/pom.xml
@jradcliff jradcliff merged commit 3c94c7b into master Apr 2, 2020
@jradcliff jradcliff deleted the depupdates branch April 2, 2020 16:16
@chuckbartz26
Copy link
Copy Markdown

da004ba@jradcliff .com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants