Add GetAccountHierarchy example#269
Merged
devchas merged 14 commits intogoogleads:masterfrom Apr 15, 2020
Merged
Conversation
nwbirnie
reviewed
Apr 6, 2020
fiboknacky
suggested changes
Apr 6, 2020
nwbirnie
suggested changes
Apr 6, 2020
nwbirnie
reviewed
Apr 6, 2020
fiboknacky
suggested changes
Apr 7, 2020
nwbirnie
suggested changes
Apr 9, 2020
fiboknacky
suggested changes
Apr 10, 2020
fiboknacky
suggested changes
Apr 13, 2020
Member
fiboknacky
left a comment
fiboknacky
left a comment
There was a problem hiding this comment.
I somehow cannot answer directly in the pending threads above. Let me copy them here:
For #269 (comment),
I partly added a comment in the relevant location too. PTAL.
Overall, I'm fine with the partial failure mode and the way you gather customer IDs to print.
However, personally, I think that should limit to the failures because of the nature of the Google Ads accounts themselves, not because the file system failure.
jradcliff
reviewed
Apr 13, 2020
fiboknacky
suggested changes
Apr 13, 2020
fiboknacky
approved these changes
Apr 15, 2020
nwbirnie
reviewed
Apr 15, 2020
jradcliff
approved these changes
Apr 15, 2020
nwbirnie
suggested changes
Apr 15, 2020
nwbirnie
approved these changes
Apr 15, 2020
nwbirnie
reviewed
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.