Add SearchForLanguageAndCarrierConstants example#271
Merged
Conversation
jradcliff
commented
Apr 8, 2020
| private void runExample(GoogleAdsClient googleAdsClient) { | ||
| GeoTargetConstantServiceClient geoTargetClient = | ||
| googleAdsClient.getLatestVersion().createGeoTargetConstantServiceClient(); | ||
| try (GeoTargetConstantServiceClient geoTargetClient = |
Member
Author
There was a problem hiding this comment.
This is the key change for this example. Ensures the service client is properly closed upon completion.
Member
Author
|
The Perl example appears to be complete now, but if there are further changes there I'll incorporate them before merging this one. |
nwbirnie
approved these changes
Apr 8, 2020
devchas
approved these changes
Apr 8, 2020
Contributor
devchas
left a comment
devchas
left a comment
There was a problem hiding this comment.
LGTM with minor nit/question.
Include leading '%' for the LIKE argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Perl library example in PR 9 (still under review).