Gen lib with new generator, method signature changes#310
Merged
Conversation
Contributor
|
The release script currently fails due to b/161541273. Workaround is available in the bug. tl;dr use JDK8 for release. |
nwbirnie
suggested changes
Jul 22, 2020
devchas
force-pushed
the
release-v4-759e2a18a5649c286b6b
branch
from
e99a083 to
7ab5fa9
Compare
devchas
changed the title
Contributor
|
I think the first line of the commit message could be more accurate here. The original message, switching to GAPICv2 covers the full scope of this change. Then we can include that, as a side-effect, we have removed some of the overloaded method signatures which were prone to cause confusion due to inclusion of boolean flags. |
devchas
force-pushed
the
release-v4-759e2a18a5649c286b6b
branch
from
7ab5fa9 to
2186eb8
Compare
devchas
changed the title
The library is now generated with a new build system. A side effect of that change is that certain overloaded method signatures containing boolean flags for making requests have been removed.
devchas
force-pushed
the
release-v4-759e2a18a5649c286b6b
branch
from
2186eb8 to
decaf29
Compare
devchas
changed the title
jradcliff
approved these changes
Jul 23, 2020
nwbirnie
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.