Skip to content

Add sample ads.properties file#341

Merged
nwbirnie merged 4 commits intogoogleads:masterfrom
nwbirnie:sampleconfig
Oct 1, 2020
Merged

Add sample ads.properties file#341
nwbirnie merged 4 commits intogoogleads:masterfrom
nwbirnie:sampleconfig

Conversation

@nwbirnie
Copy link
Copy Markdown
Contributor

Change-Id: I3e988d37954ea20c2b4dabdf99dfe4c43d506bde

Change-Id: I3e988d37954ea20c2b4dabdf99dfe4c43d506bde
Change-Id: I31158e06ad6a992969a8e29be36ddec483685991
Copy link
Copy Markdown
Contributor

@devchas devchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest uncommenting the required lines and adding INSERT_ITEM. For example

api.googleads.clientId=INSERT_CLIENT_ID

@nwbirnie
Copy link
Copy Markdown
Contributor Author

I would suggest uncommenting the required lines and adding INSERT_ITEM. For example

api.googleads.clientId=INSERT_CLIENT_ID

There's technically no required fields though... anything can be configured in code or config file or both.

I also think that it's more helpful not to put placeholders in here. I don't think anyone would have questions about where to put the details. It just means that people need to remove these before they can use the template.

@devchas devchas self-requested a review September 21, 2020 16:17
Change-Id: Ibcfe92b133d1ecddc5abda4abc74e538a7065576
Comment thread ads.properties.sample Outdated
Comment thread ads.properties.sample Outdated
Comment thread ads.properties.sample Outdated
Comment thread ads.properties.sample Outdated
Comment thread ads.properties.sample Outdated
Comment thread ads.properties.sample
Comment thread ads.properties.sample Outdated
Comment thread ads.properties.sample Outdated
@@ -0,0 +1,49 @@
# OAuth refresh token
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an intro comment that explains what this file is and points to the Getting started guide for Java.

Also, friendly reminder to update that guide to point to this sample file if you think that'd be useful.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the intro and mailed cl/334568432

Change-Id: I9b3dc121c4ae238d512bc8777a6f46cc5fc4249c
@nwbirnie nwbirnie requested a review from jradcliff September 30, 2020 11:07
Comment thread ads.properties.sample
@nwbirnie nwbirnie merged commit 7618fdb into googleads:master Oct 1, 2020
@nwbirnie nwbirnie deleted the sampleconfig branch October 1, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants