Update installed application -> desktop application#352
Merged
nwbirnie merged 1 commit intogoogleads:masterfrom Oct 27, 2020
nwbirnie:installedapp
Merged
Update installed application -> desktop application#352nwbirnie merged 1 commit intogoogleads:masterfrom nwbirnie:installedapp
nwbirnie merged 1 commit intogoogleads:masterfrom
nwbirnie:installedapp
Conversation
Change-Id: Ie786e25e983d8fdf9d559bb053d46860ea6c3913
jradcliff
reviewed
Oct 12, 2020
| * <p>This example is meant to be run from the command line and requires user input. | ||
| */ | ||
| public class AuthenticateInStandaloneApplication { | ||
| public class AuthenticateInDesktopApplication { |
Member
There was a problem hiding this comment.
WDYT of keeping this as-is? We chose the term "standalone" to try to avoid renaming the example due to minor terminology changes like this.
Contributor
Author
There was a problem hiding this comment.
Hmm, so it's definitely preferable to match the wording used in the developer documentation, particularly for new users who are not familiar with the terminology. I would guess that this changes every couple of years. If you compare this to the ~ 30 minutes of our time to update when the terminology changes I think it's a reasonable trade-off. WDYT?
Member
There was a problem hiding this comment.
Yeah, after thinking about it overnight I agree.
jradcliff
approved these changes
Oct 13, 2020
| * <p>This example is meant to be run from the command line and requires user input. | ||
| */ | ||
| public class AuthenticateInStandaloneApplication { | ||
| public class AuthenticateInDesktopApplication { |
Member
There was a problem hiding this comment.
Yeah, after thinking about it overnight I agree.
AnashOommen
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.