Conversation
Idea is to avoid issues like #412 in future.
|
|
||
| * Java 1.8+ | ||
| * Maven 3.0+ | ||
| * Protobuf 3.12.2+ |
There was a problem hiding this comment.
Are you also seeing gRPC dependencies as an issue, or is protobuf by far the most common problem?
There was a problem hiding this comment.
I'm not aware of a specific lower bound for gRPC. guava is a more common source of issues. I'll add this to the line up as well.
There was a problem hiding this comment.
I'm not trying to complicate things (honest!), but would it be better if this was a separate section, or a "Dependencies" subsection of "Requirements"?
The protobuf and guava dependency requirements are different from the Java runtime requirement. The former only come into play if the user already includes protobuf or guava as a transitive or direct dependency in their project. If not, google-ads-java will work just fine. In contrast, if the user tries to use Java 1.5 🐯 , it's likely they'll run into issues.
Perhaps something like:
## Compatible dependencies
* protobuf 3.12.2+
* guava x.y.z+
There was a problem hiding this comment.
Sounds good. Updated.
|
|
||
| * Java 1.8+ | ||
| * Maven 3.0+ | ||
| * Protobuf 3.12.2+ |
There was a problem hiding this comment.
How frequently do you anticipate this version will need to change? Wondering if it makes sense to automate keeping this in sync with poms, like you do with the library version on line 22.
There was a problem hiding this comment.
Good point, I'll add this to the release tasks for the next release.
3 participants
Idea is to avoid issues like #412 in future.