Conversation
A couple of improvements to build velocity here: - use the output files of the generate licenses task. This means that shadowJar can use the cache (can remove upToDateWhen=false). - SmokeTest is only blocking on publish to sonatype. - SmokeTest times out after 20 seconds (e.g. in case of bad OAuth credentials). - check for errors in SmokeTest (this was a bug). Change-Id: I27970e69eec8af653a2925a34220a40a929d5db1
jradcliff
reviewed
Aug 26, 2021
Change-Id: I520ee363998660c5415cf852c6df8ed722e27d44
Change-Id: Ibf8a241803dcc5047974686278d76252aa5cdec2
jradcliff
reviewed
Aug 27, 2021
Change-Id: I1b5e2d7a8e91a27c1b73848bb3830b4d29a20069
jradcliff
approved these changes
Aug 27, 2021
devchas
approved these changes
Aug 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of improvements to build velocity here:
Change-Id: I27970e69eec8af653a2925a34220a40a929d5db1