Skip to content

Override the log4j dependency used by the 'shadow' plugin#551

Merged
jradcliff merged 2 commits intomainfrom
buildenv-log4j
Jan 13, 2022
Merged

Override the log4j dependency used by the 'shadow' plugin#551
jradcliff merged 2 commits intomainfrom
buildenv-log4j

Conversation

@jradcliff
Copy link
Copy Markdown
Member

No description provided.

@PierrickVoulet
Copy link
Copy Markdown
Contributor

@jradcliff Any way to upgrade the version of the plugin itself instead?

The current version of this PR works just fine but this may lead to some additional maintenance costs later on.

@jradcliff
Copy link
Copy Markdown
Member Author

@jradcliff Any way to upgrade the version of the plugin itself instead?

The current version of this PR works just fine but this may lead to some additional maintenance costs later on.

I looked into that, but it's not clear to me if that would require upgrading Gradle itself to 7.x, so I'm making the dependency change while I'm investigating.

@jradcliff
Copy link
Copy Markdown
Member Author

@jradcliff Any way to upgrade the version of the plugin itself instead?
The current version of this PR works just fine but this may lead to some additional maintenance costs later on.

I looked into that, but it's not clear to me if that would require upgrading Gradle itself to 7.x, so I'm making the dependency change while I'm investigating.

Confirmed: this would require upgrading to 7.x.

https://github.com/johnrengelman/shadow#latest-test-compatibility

@jradcliff jradcliff merged commit 2389631 into main Jan 13, 2022
@jradcliff jradcliff deleted the buildenv-log4j branch January 13, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants