Updated dependencies to make the build run on JDK9+#58
Merged
nwbirnie merged 2 commits intogoogleads:masterfrom Feb 19, 2019
Merged
Updated dependencies to make the build run on JDK9+#58nwbirnie merged 2 commits intogoogleads:masterfrom
nwbirnie merged 2 commits intogoogleads:masterfrom
Conversation
jradcliff
approved these changes
Feb 7, 2019
Member
jradcliff
left a comment
jradcliff
left a comment
There was a problem hiding this comment.
LGTM, but added Nick as a 2nd reviewer
nwbirnie
reviewed
Feb 8, 2019
Contributor
nwbirnie
left a comment
nwbirnie
left a comment
There was a problem hiding this comment.
Could you comment on what testing has been done please?
Raibaz
force-pushed
the
jdk-11-dependencies
branch
from
7ba0f66 to
fbeda1f
Compare
Contributor
Author
|
@nwbirnie, this has been tested building and running the authentication, basicoperations and reporting examples on JDK 1.8, 10.0.2 and 11 on OS X and on JDK 1.8 on Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.