Merged
Conversation
New values adhere to the recommendations from https://developers.google.com/style/examples#example-domain-names.
Based on the PHP example from googleads/google-ads-php#887.
devchas
reviewed
Jun 14, 2023
devchas
approved these changes
Jun 14, 2023
Member
Author
|
Apologies for not clarifying before, but @fiboknacky , you can just review these 2 commits: The other commits are under review in #716. |
Member
Author
|
Merged |
Member
|
I'm reviewing it now. Just FYI. |
fiboknacky
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.