Skip to content

Remove support for v12#729

Merged
jradcliff merged 1 commit intomainfrom
remove-v12
Aug 16, 2023
Merged

Remove support for v12#729
jradcliff merged 1 commit intomainfrom
remove-v12

Conversation

@jradcliff
Copy link
Copy Markdown
Member

This version will sunset on September 27, 2023:

https://developers.google.com/google-ads/api/docs/sunset-dates

@jradcliff jradcliff requested a review from devchas August 16, 2023 15:28
Copy link
Copy Markdown
Contributor

@devchas devchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove the v12 reference in the google-ads-parent settings.gradle file? That was the only reference I could find outside of the v12 directory.

@jradcliff
Copy link
Copy Markdown
Member Author

Good point re: settings.gradle. I made that change in the first commit but GitHub is struggling mightily to show it. You can see it directly in the remove-v12 branch for this PR at https://github.com/googleads/google-ads-java/blob/remove-v12/settings.gradle, howerver.

@devchas devchas self-requested a review August 16, 2023 17:17
@jradcliff jradcliff merged commit f154ad9 into main Aug 16, 2023
@jradcliff jradcliff deleted the remove-v12 branch August 16, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants