Skip to content

Upgrade to Gradle 7.6.2 and shared dependencies 3.14.0#731

Merged
jradcliff merged 2 commits intomainfrom
shared-deps-3-14-0
Sep 5, 2023
Merged

Upgrade to Gradle 7.6.2 and shared dependencies 3.14.0#731
jradcliff merged 2 commits intomainfrom
shared-deps-3-14-0

Conversation

@jradcliff
Copy link
Copy Markdown
Member

No description provided.

Release 32.1.0 of Guava introduced a number of issues with Gradle metadata:

https://github.com/google/guava/releases/tag/v32.1.0

Upgrading to Gradle 7 avoids having to modify build files to add the
Gradle 6 workarounds for those issues.
@jradcliff
Copy link
Copy Markdown
Member Author

@devchas , @AnashOommen , you may want to review the two commits separately.

  1. Commit that upgrades Gradle to 7.6.2 has some automatically downloaded files from the upgrade process:
  • google-ads/build.gradle - REVIEW
  • gradle/wrapper/gradle-wrapper.jar - Automatically downloaded
  • gradle/wrapper/gradle-wrapper.properties - REVIEW
  • gradlew - Automatically downloaded
  • gradlew.bat - Automatically downloaded
  1. Commit that upgrades to shared deps 3.14.0 has only manual edits:
  • buildSrc/src/main/groovy/com.google.api-ads.java-conventions.gradle - REVIEW
  • google-ads/build.gradle - REVIEW

Comment thread google-ads/build.gradle
@devchas devchas self-requested a review September 5, 2023 15:33
@jradcliff jradcliff merged commit 0077c16 into main Sep 5, 2023
@jradcliff jradcliff deleted the shared-deps-3-14-0 branch September 5, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants