Add Symfony 5 support #627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeclense
approved these changes
Nov 23, 2019
Member
|
I found PHPUnit fails with Symfony 5.0. |
fiboknacky
requested review from
fiboknacky
and removed request for
thangduo
fiboknacky
requested changes
Nov 25, 2019
Member
fiboknacky
left a comment
fiboknacky
left a comment
There was a problem hiding this comment.
PHPUnit tests fail. Please fix them first.
Author
|
will take a look when have free time |
Closed
Member
|
Author
|
unfortunetly not. there is something with the way this lib uses symfony library but I haven't got to actually debugging / fixing this issue |
Member
|
This is merged in #638. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Symfony 5 support
#SymfonyHackday