Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

chore: Clean up dead code and linter errors#1166

Merged
mctavish merged 1 commit intogoogleapis:mainfrom
mctavish:lint-cleanup
Sep 7, 2023
Merged

chore: Clean up dead code and linter errors#1166
mctavish merged 1 commit intogoogleapis:mainfrom
mctavish:lint-cleanup

Conversation

@mctavish
Copy link
Contributor

@mctavish mctavish commented Sep 7, 2023

This PR fixes linter errors and removes some dead code as well as commented-out test code that will not be brought back.

@mctavish mctavish requested a review from a team as a code owner September 7, 2023 17:13
@mctavish mctavish requested a review from a team September 7, 2023 17:14
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Sep 7, 2023
@mctavish mctavish requested a review from jasonborg September 7, 2023 17:14
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +7.21% 🎉

Comparison is base (4c1e453) 54.51% compared to head (7ed0a8e) 61.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
+ Coverage   54.51%   61.72%   +7.21%     
==========================================
  Files          18       17       -1     
  Lines        1495     1309     -186     
  Branches      290      257      -33     
==========================================
- Hits          815      808       -7     
+ Misses        626      447     -179     
  Partials       54       54              
Files Changed Coverage Δ
src/agent/firebase-controller.ts 64.75% <50.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2023
@mctavish mctavish merged commit 65ba82f into googleapis:main Sep 7, 2023
@mctavish mctavish deleted the lint-cleanup branch September 7, 2023 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants