This repository was archived by the owner on Apr 3, 2024. It is now read-only.
chore: Clean up dead code and linter errors#1166
Merged
mctavish merged 1 commit intogoogleapis:mainfrom Sep 7, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
+ Coverage 54.51% 61.72% +7.21%
==========================================
Files 18 17 -1
Lines 1495 1309 -186
Branches 290 257 -33
==========================================
- Hits 815 808 -7
+ Misses 626 447 -179
Partials 54 54
☔ View full report in Codecov by Sentry. |
jasonborg
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes linter errors and removes some dead code as well as commented-out test code that will not be brought back.