fix: parse the response body message to determine retry backoff by nolanmar511 · Pull Request #249 · googleapis/cloud-profiler-nodejs

nolanmar511 · 2018-07-11T00:37:15Z

This fixes #245.

Sign in to view

                             statusCode: 409,
-                             body: {error: {details: [{retryDelay: '50s'}]}}
+                             body: {
+                               message: 'action throttled, backoff for 50s',


Sign in to view

+  // The response currently does not have field containing the retry duration.
+  // As a work-around, response body's message is parsed to get the backoff 
+  // duration.
+  // TODO: Remove this work-around and get the retry delay from


codecov · 2018-07-12T22:59:41Z

Codecov Report

Merging #249 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #249      +/-   ##
========================================
+ Coverage   89.94%    90%   +0.05%     
========================================
  Files           6      6              
  Lines         388    390       +2     
  Branches       69     68       -1     
========================================
+ Hits          349    351       +2     
  Misses         39     39

Impacted Files	Coverage Δ
ts/src/profiler.ts	`95.85% <100%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da64079...0d0cc16. Read the comment docs.

nolanmar511 · 2018-07-12T23:19:27Z

PTAL

aalexand

Thank you, I think it's almost done, just couple comments.

Sign in to view

+  // The response currently does not have field containing the server-specified
+  // backoff. As a workaround, response body's message is parsed to get the
+  // backoff.
+  // TODO: Remove this work-around and get the retry delay from


Sign in to view

+  // The response currently does not have field containing the server-specified
+  // backoff. As a workaround, response body's message is parsed to get the
+  // backoff.
+  // TODO: Remove this work-around and get the retry delay from


Sign in to view

+ */
+export function parseBackoffDuration(backoffStr: string): number|undefined {
+  const found = backoffStr.match(BACKOFF_MSG_PAT);
+  if (found && found.length >= 2 && typeof found[1] === 'string') {


Sign in to view

      GTEST_VERSION="${GTEST_MIN_VERSION}"])

-# TODO(chandlerc@google.com) Check the types, structures, and other compiler
+# (chandlerc@google.com) Check the types, structures, and other compiler


Sign in to view

+}
+
+
+const BACKOFF_MSG_PATH =


nolanmar511 · 2018-07-13T18:00:07Z

PTAL

aalexand · 2018-07-13T22:45:37Z

@nolanmar511 The CI test failed on node10?

aalexand · 2018-07-13T22:49:39Z

@nolanmar511 Please merge once node10 CI is passing. (assuming ofrobots@ doesn't have more comments)

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 11, 2018

nolanmar511 mentioned this pull request Jul 11, 2018

Remove hack for determining server-specified retry backoff #250

Closed

aalexand reviewed Jul 11, 2018

View reviewed changes

fix: parse the response body message to determine retry backoff

d565042

nolanmar511 force-pushed the update-common branch from e48b9fc to c9ef41b Compare July 12, 2018 23:07

aalexand reviewed Jul 12, 2018

View reviewed changes

nolanmar511 force-pushed the update-common branch from c9ef41b to d531663 Compare July 13, 2018 15:02

address comments

15846f8

nolanmar511 force-pushed the update-common branch from d531663 to 15846f8 Compare July 13, 2018 17:16

ofrobots reviewed Jul 13, 2018

View reviewed changes

aalexand reviewed Jul 13, 2018

View reviewed changes

Comment thread ts/src/profiler.ts Outdated

}

const BACKOFF_MSG_PATH =

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

nolanmar511 force-pushed the update-common branch 2 times, most recently from cf6ca14 to bb429ae Compare July 13, 2018 17:54

nolanmar511 force-pushed the update-common branch from bb429ae to c5e047c Compare July 13, 2018 19:52

aalexand approved these changes Jul 13, 2018

View reviewed changes

ofrobots approved these changes Jul 13, 2018

View reviewed changes

ofrobots mentioned this pull request Jul 13, 2018

chore(deps): update dependency gts to ^0.8.0 #253

Merged

address comments

0d0cc16

nolanmar511 force-pushed the update-common branch from c5e047c to 0d0cc16 Compare July 13, 2018 23:49

nolanmar511 merged commit 52003c8 into googleapis:master Jul 16, 2018

snyk-bot mentioned this pull request Feb 8, 2020

[Snyk] Upgrade @google-cloud/profiler from 0.1.14 to 0.2.3 suniltib/microservices-demo#5

Open

Conversation

nolanmar511 commented Jul 11, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

codecov Bot commented Jul 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nolanmar511 commented Jul 12, 2018

Uh oh!

aalexand left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

nolanmar511 commented Jul 13, 2018

Uh oh!

aalexand commented Jul 13, 2018

Uh oh!

aalexand commented Jul 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jul 12, 2018 •

edited

Loading