This repository was archived by the owner on Feb 20, 2026. It is now read-only.
chore: silence deprecation warnings that appear with gcc 8#424
Merged
kalyanac merged 2 commits intogoogleapis:masterfrom Feb 25, 2019
Merged
chore: silence deprecation warnings that appear with gcc 8#424kalyanac merged 2 commits intogoogleapis:masterfrom
kalyanac merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
nolanmar511
changed the title
aalexand
reviewed
Feb 25, 2019
| ], | ||
| "include_dirs": [ "<!(node -e \"require('nan')\")" ] | ||
| "include_dirs": [ "<!(node -e \"require('nan')\")" ], | ||
| "cflags": [ "-Wno-cast-function-type" ] |
Contributor
There was a problem hiding this comment.
It would be good to add a comment here on why it's added.
This was referenced Feb 26, 2019
imsky
added a commit
to better/node-expat
that referenced
this pull request
Apr 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodejs/nan#807 (comment) recommends using the "-Wno-cast-function-type" to silence deprecations warnings that appear with GCC 8.
Silences warnings users see in #315.