Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

chore: add comment to explain suppressed compilation warnings #428

Merged
aalexand merged 2 commits into from
Feb 27, 2019
Merged

chore: add comment to explain suppressed compilation warnings #428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31f6868
chore: add comment to explain supressed compilation warnings
nolanmar511 Feb 27, 2019
650577f
Merge branch 'master' into comment-compile-warning
JustinBeckwith Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
"bindings/profiler.cc",
],
"include_dirs": [ "<!(node -e \"require('nan')\")" ],
# TODO(#315): The following line suppresses compliation warnings
# originating from v8 and node that appear when gcc 8 is used.
# Once the warnings are fixed upstream, this line should be removed.
"cflags": [ "-Wno-cast-function-type" ]
},
{
Expand Down