This repository was archived by the owner on Nov 21, 2025. It is now read-only.
refactor: explicitly assign every internal config field #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
- Coverage 94.81% 94.81% -0.01%
==========================================
Files 97 96 -1
Lines 6150 6186 +36
Branches 486 481 -5
==========================================
+ Hits 5831 5865 +34
- Misses 165 166 +1
- Partials 154 155 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
=========================================
- Coverage 94.81% 94.8% -0.01%
=========================================
Files 97 96 -1
Lines 6211 6239 +28
Branches 486 483 -3
=========================================
+ Hits 5889 5915 +26
- Misses 183 184 +1
- Partials 139 140 +1
Continue to review full report at Codecov.
|
ofrobots
reviewed
May 8, 2019
ofrobots
approved these changes
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite to addressing a feature request in #994... this change makes every internal config option assignment explicit, and re-organizes internal config options so that instead of
interface ParentConfig extends ChildConfigit becomesinterface ParentConfig { childConfig: ChildConfig }. This means that each configurable component (internally) only gets config options that it asks for, rather than a large object containing all config options.Tested behavior should remain the same; some tests have been changed because of the re-organization of internal options.