Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

test: relax aborted span test#1104

Merged
kjin merged 1 commit intogoogleapis:masterfrom
kjin:aborted-2
Aug 19, 2019
Merged

test: relax aborted span test#1104
kjin merged 1 commit intogoogleapis:masterfrom
kjin:aborted-2

Conversation

@kjin
Copy link
Copy Markdown
Contributor

@kjin kjin commented Aug 19, 2019

The aborted span test is the # 1 cause of flakes. By waiting 1000ms instead of 600ms, I hope this will reduce the number of flaky results.

@kjin kjin requested a review from a team August 19, 2019 17:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2019

Codecov Report

Merging #1104 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1104   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          98       98           
  Lines        6450     6450           
  Branches      499      499           
=======================================
  Hits         6127     6127           
  Misses        166      166           
  Partials      157      157
Impacted Files Coverage Δ
test/test-trace-web-frameworks.ts 98.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0e39f...3719f50. Read the comment docs.

@kjin kjin merged commit 417b8d5 into googleapis:master Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants