This repository was archived by the owner on Jan 21, 2026. It is now read-only.
chore: re-enable node 10 ci and modify init-test-fixtures#771
Merged
kjin merged 1 commit intogoogleapis:masterfrom Jun 11, 2018
Merged
chore: re-enable node 10 ci and modify init-test-fixtures#771kjin merged 1 commit intogoogleapis:masterfrom
kjin merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
kjin
force-pushed
the
node-10-4
branch
2 times, most recently
from
7382f76 to
671a5c0
Compare
ofrobots
approved these changes
Jun 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables Node 10 CI. It also modifies
init-test-fixturesto re-install gRPC binaries if there is a module version mismatch, and allowsengines.nodeinplugin-fixtures.jsonto dictate whether the fixture is actually installed (at this time, there is only gRPC 1.6). The former doesn't affect CI, it is purely for developer convenience when switching between Node versions locally.