impl(bq_driver): Migration sripts#1315
Conversation
Khushikathuria008
temporarily deployed
to
internal
GitHub Actions
Inactive
|
The scripts should copy/replace the only DSN if a single DSN was present. In case of multiple, we should prompt the user to choose one. |
Khushikathuria008
force-pushed
the
migration
branch
from
a9baaf0 to
eb80272
Compare
Khushikathuria008
temporarily deployed
to
internal
GitHub Actions
Inactive
Khushikathuria008
force-pushed
the
migration
branch
from
eb80272 to
44c6fe9
Compare
Khushikathuria008
temporarily deployed
to
internal
GitHub Actions
Inactive
Khushikathuria008
temporarily deployed
to
internal
GitHub Actions
Inactive
Khushikathuria008
temporarily deployed
to
internal
GitHub Actions
Inactive
done |
|
|
||
| # Migration script for Linux/MacOS ODBC DSNs | ||
| # - Migrates from "Simba Google BigQuery ODBC Connector" | ||
| # - to "Google ODBC Driver for Google BigQuery" |
There was a problem hiding this comment.
please change the name of the driver here and elsewhere to "ODBC Driver for BigQuery"
Khushikathuria008
temporarily deployed
to
internal
GitHub Actions
Inactive
shivamd-gpartner
left a comment
shivamd-gpartner
left a comment
There was a problem hiding this comment.
Looks fine for now
| @@ -0,0 +1,225 @@ | |||
| # !/usr/bin/env powershell | |||
There was a problem hiding this comment.
Please attach a readme mentioning the behaviour of these scripts and the usage in detail. For e.g., explain when will it ask for DSN name to be copied or replaced.
Khushikathuria008
force-pushed
the
migration
branch
from
d82f669 to
01fced3
Compare
| | Copy mode | `<DSN>_Google` | `<DSN>_google` | | ||
| | Replace mode | In‑place | In‑place | | ||
| | Multi‑DSN prompt | Yes | Yes | | ||
| | Backup created | Implicit (registry) | Explicit `.bak.<timestamp>` | |
There was a problem hiding this comment.
.<timestamp> seems like a weird extension. Can we keep the same extension and just add _bak_<timestamp> to the filename?
| | Windows | Registry (ODBC.INI, ODBCINST.INI) | | ||
| | Linux/macOS | `odbc.ini` | | ||
|
|
||
| All scripts create backups before modifying configuration. |
There was a problem hiding this comment.
The backup should only be created when the copy option is selected. In case of replace, we can replace the particular DSN section in the ini file(s).
|
@Khushikathuria008 How have we verified these scripts? |
There was a problem hiding this comment.
As discussed, @shivamd-gpartner, lets find a smart way to modify the existing integration test pipelines to migrate the Existing Driver DSN to ours using these scripts.
5 participants
No description provided.