fix encoding#1506
Draft
shivamd-gpartner wants to merge 21 commits into
Draft
Conversation
shivamd-gpartner
temporarily deployed
to
internal
GitHub Actions
Inactive
shivamd-gpartner
force-pushed
the
test_hana
branch
from
735d19f to
873b9da
Compare
shivamd-gpartner
temporarily deployed
to
internal
GitHub Actions
Inactive
shivamd-gpartner
temporarily deployed
to
internal
GitHub Actions
Inactive
shivamd-gpartner
force-pushed
the
test_hana
branch
13 times, most recently
from
311c71e to
814c1fb
Compare
shivamd-gpartner
force-pushed
the
test_hana
branch
from
511f04e to
7b8b154
Compare
shivamd-gpartner
force-pushed
the
test_hana
branch
3 times, most recently
from
f9232a2 to
9ce5ad1
Compare
shivamd-gpartner
force-pushed
the
test_hana
branch
4 times, most recently
from
07fe46c to
c350b18
Compare
sachinpro
reviewed
May 7, 2026
| std::regex named_pattern(R"([:@]\w+)"); | ||
|
|
||
| // Check for positional parameters | ||
| if (std::regex_search(query, positional_pattern)) { |
Collaborator
There was a problem hiding this comment.
Let's deep dive into the reason this was crashing.
Let's print query and positional_pattern. Let's write a small c++ application to verify that it crashes independently.
shivamd-gpartner
force-pushed
the
test_hana
branch
from
3ae14c6 to
79a7205
Compare
Collaborator
|
Let's check if |
This reverts commit da09558.
shivamd-gpartner
force-pushed
the
test_hana
branch
from
da09558 to
edbd250
Compare
shivamd-gpartner
force-pushed
the
test_hana
branch
from
bca1d00 to
12da683
Compare
This reverts commit 12da683.
This reverts commit a5c1842.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.