Skip to content

chore: fix several golden issues #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
viacheslav-rostovtsev merged 4 commits into from
Sep 8, 2025
Merged

chore: fix several golden issues #1226

viacheslav-rostovtsev merged 4 commits into from
Sep 8, 2025

Conversation

@viacheslav-rostovtsev
Copy link
Member

@viacheslav-rostovtsev viacheslav-rostovtsev commented Sep 8, 2025

  • add shortname to goldens and regenerate repo-metadata
  • re-add golden for cloud noservice
  • fix extraneous dependency in testing

@viacheslav-rostovtsev viacheslav-rostovtsev requested a review from a team as a code owner September 8, 2025 17:45
aandreassa
aandreassa previously approved these changes Sep 8, 2025
View reviewed changes
@viacheslav-rostovtsev viacheslav-rostovtsev added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2025
@viacheslav-rostovtsev viacheslav-rostovtsev merged commit 3b37229 into googleapis:main Sep 8, 2025
5 checks passed
@viacheslav-rostovtsev viacheslav-rostovtsev mentioned this pull request Sep 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aandreassa aandreassa aandreassa approved these changes

Assignees

No one assigned

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@viacheslav-rostovtsev @aandreassa