Skip to content

feat: Add channel pooling for gapic clients#969

Merged
diptanshumittal merged 8 commits intomainfrom
feat_channel_pool
Aug 17, 2023
Merged

feat: Add channel pooling for gapic clients#969
diptanshumittal merged 8 commits intomainfrom
feat_channel_pool

Conversation

@diptanshumittal
Copy link
Copy Markdown
Contributor

No description provided.

@diptanshumittal diptanshumittal marked this pull request as ready for review August 7, 2023 17:55
@diptanshumittal diptanshumittal requested a review from a team August 7, 2023 17:55
@diptanshumittal diptanshumittal enabled auto-merge (squash) August 7, 2023 17:55
Comment thread gapic-common/lib/gapic/grpc/service_stub.rb
Comment thread gapic-common/lib/gapic/grpc/service_stub.rb
Comment thread gapic-common/lib/gapic/grpc/service_stub.rb Outdated
Comment thread gapic-common/lib/gapic/grpc/service_stub.rb Outdated
Comment thread gapic-common/lib/gapic/grpc/service_stub.rb Outdated
Comment thread gapic-common/lib/gapic/grpc/service_stub/channel_pool.rb
Comment thread gapic-common/lib/gapic/grpc/service_stub/channel_pool.rb
Comment thread gapic-common/lib/gapic/grpc/service_stub/channel_pool.rb Outdated
Comment thread gapic-common/lib/gapic/grpc/service_stub/channel_pool.rb Outdated
Comment thread gapic-common/lib/gapic/grpc/service_stub/channel_pool.rb Outdated
@diptanshumittal diptanshumittal added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2023
@diptanshumittal diptanshumittal removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 10, 2023
Copy link
Copy Markdown
Contributor

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a couple final items.

Comment thread gapic-common/lib/gapic/grpc/service_stub.rb Outdated
Comment thread gapic-common/lib/gapic/grpc/service_stub/channel_pool.rb Outdated
@diptanshumittal diptanshumittal force-pushed the feat_channel_pool branch 2 times, most recently from db37659 to 1edddfa Compare August 17, 2023 14:01
Copy link
Copy Markdown
Contributor

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants