Skip to content

chore: Migrate more rake tasks to toys#980

Merged
dazuma merged 1 commit intogoogleapis:mainfrom
dazuma:pr/toys-scripts
Aug 31, 2023
Merged

chore: Migrate more rake tasks to toys#980
dazuma merged 1 commit intogoogleapis:mainfrom
dazuma:pr/toys-scripts

Conversation

@dazuma
Copy link
Copy Markdown
Contributor

@dazuma dazuma commented Aug 31, 2023

Includes:

  • Updated Gemfile.lock files
  • Updated Ruby versions for CI
  • Consolidated logic for regenerating binary proto input and golden outputs into the toys scripts in the shared directory
  • Support common Toys tools (e.g. test, etc.) in all gem directories
  • Fixed a few rubocop errors caught by newer versions of rubocop.

Deferred until follow-up PRs:

  • Removing the old Rakefiles
  • Regenerating shared input and output files from the latest protos
  • Output tests are currently disabled for wrappers—need a directory structure fix to re-enable
  • Readme needs to be updated

@dazuma dazuma requested a review from a team August 31, 2023 21:28
@dazuma dazuma merged commit 7ab2330 into googleapis:main Aug 31, 2023
@dazuma dazuma deleted the pr/toys-scripts branch August 31, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant