This repository was archived by the owner on Sep 26, 2023. It is now read-only.
chore: Add maven clirr check #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Seeing that this PR has the Sonar workflow work. I'm guessing there is a syntax error in #1847 |
blakeli0
reviewed
Oct 27, 2022
| - uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 11 |
Contributor
There was a problem hiding this comment.
We'll be supporting Java 8 for a while, do we want to use Java 8 here?
Member
Author
There was a problem hiding this comment.
Makes sense. I've added both Java 8 and 11. The mvn install fails with the <release>8</release> flag in the maven-compiler-plugin on Java 8 (so compilation with still be with Java 11).
|
Kudos, SonarCloud Quality Gate passed!
|
blakeli0
approved these changes
Nov 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.