chore: Don't generate testlib for parent and bom

[lqiu96]

No description provided.

[blakeli0]

This PR makes me think that maybe we should explicitly creating test jars in the three child poms, instead of trying to create test jars for all 5 and skipping 2. It would also make this section much shorter and clearer in each child pom.

[lqiu96]

This PR makes me think that maybe we should explicitly creating test jars in the three child poms, instead of trying to create test jars for all 5 and skipping 2. It would also make this section much shorter and clearer in each child pom.

@blakeli0 Yep, makes sense. The test-jar config comes from shared-configs at: https://github.com/googleapis/java-shared-config/blob/59a7b6d612aee531342410d0adc3ea161c26fea0/pom.xml#L340 so I would still need to explicitly skip for the parent and the BOM.

Do you think it would be cleaner to just add in skip for the parent and the BOM and move

                <include>com/google/api/gax/core/**</include> -> `Move to gax`
                <include>com/google/api/gax/rpc/testing/**</include> -> `Move to gax`
                <include>com/google/api/gax/rpc/mtls/**</include> -> `Move to gax`
                <include>com/google/api/gax/grpc/testing/**</include> -> `Move to gax-grpc`
                <include>com/google/api/gax/httpjson/testing/**</include> -> `Move to gax-httpjson`

to their respective modules?

I added in <skip.generate.testlib> property for clarity, but it might have actually added in more clutter...

[blakeli0]

Do you think it would be cleaner to just add in skip for the parent and the BOM and move

                <include>com/google/api/gax/core/**</include> -> `Move to gax`
                <include>com/google/api/gax/rpc/testing/**</include> -> `Move to gax`
                <include>com/google/api/gax/rpc/mtls/**</include> -> `Move to gax`
                <include>com/google/api/gax/grpc/testing/**</include> -> `Move to gax-grpc`
                <include>com/google/api/gax/httpjson/testing/**</include> -> `Move to gax-httpjson`

to their respective modules?

Yes, that is much cleaner. We also don't need a <skip.generate.testlib> property. Currently we have this section declared in the parent pom with a skip = True, which could be very confusion to other people.

[lqiu96]

@blakeli0 PTAL

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication