This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Fix error propagtion for ServerStreamIterators.#455
Merged
garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom Jan 8, 2018
Merged
Fix error propagtion for ServerStreamIterators.#455garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom
garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom
Conversation
Currently the ServerStreamIterator blindly re-throws errors encountered in the async ResponseObserver. However this creates a confusing stacktrace which does not include any of the frames from the sync invocation of .next(). This PR wraps the async errors in a RuntimeException so that both stacktraces are accounted for.
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
============================================
+ Coverage 71.72% 71.77% +0.05%
Complexity 746 746
============================================
Files 154 154
Lines 3331 3330 -1
Branches 258 258
============================================
+ Hits 2389 2390 +1
+ Misses 844 842 -2
Partials 98 98
Continue to review full report at Codecov.
|
pongad
reviewed
Jan 8, 2018
Contributor
pongad
left a comment
pongad
left a comment
There was a problem hiding this comment.
LGTM. @garrettjonesgoogle PTAL
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the ServerStreamIterator blindly re-throws errors encountered in the async
ResponseObserver. However this creates a confusing stacktrace which does not include any
of the frames from the sync invocation of .next(). This PR wraps the async errors in a
RuntimeException so that both stacktraces are accounted for.