This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Revert "Update the ResumptionStrategy interface to allow it to modify the incoming response stream. #495
Closed
igorbernstein2 wants to merge 1 commit intogoogleapis:masterfrom
Conversation
… the incoming response stream. (googleapis#485)" This reverts commit 7d0a0a0.
Contributor
Author
|
@garrettjonesgoogle please merge if you agree. If you think it's useful to keep, please close this PR |
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
========================================
Coverage 70.5% 70.5%
Complexity 810 810
========================================
Files 165 165
Lines 3773 3773
Branches 289 289
========================================
Hits 2660 2660
Misses 990 990
Partials 123 123
Continue to review full report at Codecov.
|
Member
|
So there is a renaming in the original PR. I'd prefer not to flip-flop on naming. Also, there is very little overhead in this feature. I think we should just keep it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize for the noise, I thought I could use this functionality for batching in googleapis/google-cloud-java#3026, but turns out I was wrong and had to implement a custom attempt callable regardless.
I still think this functionality (along with response suppression) can be useful for spanner, but I figured I'd revert it until it is actually needed.