This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Batching - allow null entries#496
Merged
garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom Mar 13, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
===========================================
+ Coverage 70.5% 70.5% +<.01%
Complexity 810 810
===========================================
Files 165 165
Lines 3773 3774 +1
Branches 289 289
===========================================
+ Hits 2660 2661 +1
Misses 990 990
Partials 123 123
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came out of working on googleapis/google-cloud-java#3026.
A Bigtable
MutateRowsResponsecontains a list of entries. Each entry simply contains aStatusindicating if that entry succeeded or failed. Since the user only cares if the entry failed, the most useful type signature for aBatchingCallablerepresenting the RPC would beBatchingCallable<MutateRowsRequest, Void>.Unfortunately,
BatchedRequestIssuertreatsnullresponse as absent. This PR adds an explicithasResponseflag to check for missing responses, which allows for null responses forVoidentries