Skip to content

Temporary workaround for protobuf extension issue#199

Merged
tmatsuo merged 2 commits intogoogleapis:masterfrom
tmatsuo:bandaid-for-protobuf-4761
Jul 18, 2018
Merged

Temporary workaround for protobuf extension issue#199
tmatsuo merged 2 commits intogoogleapis:masterfrom
tmatsuo:bandaid-for-protobuf-4761

Conversation

@tmatsuo
Copy link
Copy Markdown
Contributor

@tmatsuo tmatsuo commented Jul 18, 2018

@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jul 18, 2018

@dwsupplee This is a new PR with comparators and an exporter. PTAL

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 18, 2018

Codecov Report

Merging #199 into master will decrease coverage by 0.09%.
The diff coverage is 74.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #199     +/-   ##
=========================================
- Coverage   84.39%   84.29%   -0.1%     
=========================================
  Files          58       62      +4     
  Lines        2788     2815     +27     
=========================================
+ Hits         2353     2373     +20     
- Misses        435      442      +7
Impacted Files Coverage Δ
...rc/ApiCore/Testing/MessageAwareArrayComparator.php 0% <0%> (ø)
src/ApiCore/Testing/MessageAwareExporter.php 100% <100%> (ø)
src/ApiCore/Testing/ProtobufGPBEmptyComparator.php 66.66% <66.66%> (ø)
src/ApiCore/Testing/ProtobufMessageComparator.php 78.57% <78.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d099c...01378c9. Read the comment docs.

Copy link
Copy Markdown
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@tmatsuo tmatsuo merged commit 02d5470 into googleapis:master Jul 18, 2018
@tmatsuo tmatsuo deleted the bandaid-for-protobuf-4761 branch July 18, 2018 21:31
@tmatsuo tmatsuo mentioned this pull request Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants