Preparatory refactoring to add grpc-fallback support#201
Preparatory refactoring to add grpc-fallback support#201michaelbausor merged 3 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 84.29% 84.14% -0.16%
==========================================
Files 62 63 +1
Lines 2815 2826 +11
==========================================
+ Hits 2373 2378 +5
- Misses 442 448 +6
Continue to review full report at Codecov.
|
| /** | ||
| * An trait for shared functionality between Guzzle HTTP-based transports. | ||
| */ | ||
| trait GuzzleTransportTrait |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
left a comment
dwsupplee
left a comment
There was a problem hiding this comment.
Looks good, just a few minor nits.
src/ApiCore/ApiException.php
Outdated
| * @return ApiException | ||
| */ | ||
| public static function createFromApiResponse($basicMessage, $rpcCode, $metadata = null) | ||
| public static function createFromApiResponse($basicMessage, $rpcCode, $metadata = null, $previous = null) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| use Google\Auth\HttpHandler\HttpHandlerFactory; | ||
|
|
||
| /** | ||
| * An trait for shared functionality between transports that support only unary RPCs using simple |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
3 participants
This PR is intended to prepare the ground for adding support for the grpc-fallback transport (serial protobuf over HTTP 1.1). It: