Refactor AgentHeaderDescriptor#206
Conversation
michaelbausor
commented
Aug 14, 2018
- Replace AgentHeaderDescriptor with AgentHeader, a class with only static methods
- In GapicClientTrait, cache only the gapic version loaded from file
- Remove AgentHeaderMiddleware and use FixedHeaderMiddleware in its place
| * @return string | ||
| */ | ||
| public static function getApiCoreVersion() | ||
| public static function readGapicVersionFromFile($callingClass) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| public static function readVersionFile($file) | ||
| { | ||
| $versionString = @file_get_contents($file) ?: ""; | ||
| return trim($versionString); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks like there's a cs error, feel free to merge once it's fixed |
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 84.14% 84.81% +0.66%
==========================================
Files 63 62 -1
Lines 2826 2838 +12
==========================================
+ Hits 2378 2407 +29
+ Misses 448 431 -17
Continue to review full report at Codecov.
|