Skip to content

Remove common protos#220

Merged
michaelbausor merged 8 commits intogoogleapis:masterfrom
michaelbausor:remove-common-protos
Dec 11, 2018
Merged

Remove common protos#220
michaelbausor merged 8 commits intogoogleapis:masterfrom
michaelbausor:remove-common-protos

Conversation

@michaelbausor
Copy link
Copy Markdown
Contributor

@michaelbausor michaelbausor commented Dec 10, 2018

Removes common protos and adds dependency on google/common-protos

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 10, 2018

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #220   +/-   ##
======================================
  Coverage    84.7%   84.7%           
======================================
  Files          64      64           
  Lines        2471    2471           
======================================
  Hits         2093    2093           
  Misses        378     378

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8728300...218520a. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 10, 2018 •
edited
Loading

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #220   +/-   ##
======================================
  Coverage    84.7%   84.7%           
======================================
  Files          64      64           
  Lines        2471    2471           
======================================
  Hits         2093    2093           
  Misses        378     378

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8728300...97b77a1. Read the comment docs.

dwsupplee
dwsupplee reviewed Dec 10, 2018
View reviewed changes
dwsupplee
dwsupplee reviewed Dec 10, 2018
View reviewed changes
dwsupplee
dwsupplee approved these changes Dec 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@michaelbausor michaelbausor merged commit a69d51e into googleapis:master Dec 11, 2018
@michaelbausor michaelbausor deleted the remove-common-protos branch December 11, 2018 16:26
@michaelbausor michaelbausor mentioned this pull request Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshaffer bshaffer Awaiting requested review from bshaffer

@tmatsuo tmatsuo Awaiting requested review from tmatsuo

@jdpedrie jdpedrie Awaiting requested review from jdpedrie

1 more reviewer

@dwsupplee dwsupplee dwsupplee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelbausor @codecov-io @dwsupplee @googlebot