Chore: Python-Spanner-Driver | Spannerlib Wrapper | Project Setup #656

bhatt4982 · 2025-12-01T11:11:36Z

Project setup for Spannerlib-Python

gemini-code-assist · 2025-12-01T11:12:09Z

Summary of Changes

Hello @bhatt4982, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request lays the groundwork for the spannerlib-python project, a Python wrapper designed to provide a high-performance interface to Google Cloud Spanner by leveraging its Go client shared library. The changes establish a robust project setup, including essential configuration for building, testing, and packaging the library, alongside initial documentation and licensing. This foundational work is crucial for future development and integration of the Spanner client within the Python ecosystem.

Highlights

Initial Project Structure: Established the foundational directory and file structure for the spannerlib-python wrapper, including Python package directories, test directories, and a samples folder.
Build and Packaging Configuration: Introduced pyproject.toml for modern Python packaging, setup.py for setuptools, MANIFEST.in for including non-Python files, and requirements.txt for dependencies.
Automated Workflow Setup (Nox): Configured noxfile.py to automate common development tasks such as code formatting (Black, Isort), linting (Flake8), running unit and system tests, and managing the build process for the Python package.
Shared Library Integration: Added build-shared-lib.sh and related Nox sessions to handle the building and copying of platform-specific Go Spanner client shared library binaries, which the Python wrapper will interface with.
Documentation and Licensing: Included a comprehensive README.md with instructions for setup, testing, and building, along with the Apache License 2.0.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request does a great job of setting up the initial project structure for spannerlib-python, including configurations for building, packaging, testing, and linting. The setup is comprehensive. My review provides feedback to enhance the robustness and cross-platform compatibility of the build scripts, improve test configurations, and address minor issues in documentation and placeholder files. Key suggestions include adding set -e to the build script for safer execution, resolving the non-portable use of bash in noxfile.py, and correcting placeholder test files.

spannerlib/wrappers/spannerlib-python/spannerlib-python/build-shared-lib.sh

spannerlib/wrappers/spannerlib-python/spannerlib-python/noxfile.py

spannerlib/wrappers/spannerlib-python/spannerlib-python/README.md

spannerlib/wrappers/spannerlib-python/spannerlib-python/noxfile.py

spannerlib/wrappers/spannerlib-python/spannerlib-python/samples/requirements.txt

spannerlib/wrappers/spannerlib-python/spannerlib-python/tests/system/test_placeholder.py

spannerlib/wrappers/spannerlib-python/spannerlib-python/tests/unit/test_placeholder.py

bhatt4982 · 2025-12-02T05:20:46Z

/gemini review

gemini-code-assist

Code Review

This pull request sets up the initial project structure for spannerlib-python. The setup includes configuration for building, testing, linting, and packaging using nox and setuptools. The overall structure is solid, but I've identified a few issues, primarily in the build scripts and CI configuration, that should be addressed. My main concerns are a critical path issue in the build script, lack of testing across all supported Python versions, and missing support for Intel-based Macs. I've left detailed comments with suggestions for each point.

spannerlib/wrappers/spannerlib-python/spannerlib-python/build-shared-lib.sh

spannerlib/wrappers/spannerlib-python/spannerlib-python/noxfile.py

spannerlib/wrappers/spannerlib-python/spannerlib-python/README.md

spannerlib/wrappers/spannerlib-python/spannerlib-python/build-shared-lib.sh

spannerlib/wrappers/spannerlib-python/spannerlib-python/noxfile.py

bhatt4982 · 2025-12-02T06:25:02Z

/gemini review

gemini-code-assist

Code Review

This pull request sets up the initial project structure for spannerlib-python. The setup is comprehensive, including build scripts, packaging configuration with pyproject.toml, testing setup with nox, and CI-friendly shell scripts. My review focuses on improving the robustness and maintainability of the setup files. I've suggested a few changes to the README.md for clarity, improvements to the build script for simplicity and portability, and removal of some redundant code in noxfile.py and setup.py. Overall, this is a solid foundation for the new package.

spannerlib/wrappers/spannerlib-python/spannerlib-python/README.md

spannerlib/wrappers/spannerlib-python/spannerlib-python/build-shared-lib.sh

spannerlib/wrappers/spannerlib-python/spannerlib-python/noxfile.py

spannerlib/wrappers/spannerlib-python/spannerlib-python/setup.py

…sts.

…kage installation after other dependencies.

…ript robustness with `set -e`.

…unit/test_placeholder.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…nt in build script

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…p.py.

…o 80.

olavloite

Feel free to address any review comments that need any changes in a follow-up PR.

spannerlib/wrappers/spannerlib-python/README.md

...ib/wrappers/spannerlib-python/spannerlib-python/google/cloud/spannerlib/internal/__init__.py

spannerlib/wrappers/spannerlib-python/spannerlib-python/samples/requirements.txt

spannerlib/wrappers/spannerlib-python/spannerlib-python/build-shared-lib.sh

spannerlib/wrappers/spannerlib-python/spannerlib-python/noxfile.py

spannerlib/wrappers/spannerlib-python/spannerlib-python/pyproject.toml

spannerlib/wrappers/spannerlib-python/spannerlib-python/README.md

…dle spannerlib library interaction (#657) * feat: Add initial Python wrapper for Spanner library, including internal message structures, error handling, and a protocol definition. * refactor: Introduce `_load_library` for library initialization, remove `_get_lib_path`, and update related tests. * Chore: Python-Spanner-Driver | Spannerlib Wrapper | Added Pool class and relevant tests (#658) * feat: Introduce AbstractLibraryObject and Pool modules with their unit and system tests, replacing placeholder tests. * Chore: Python-Spanner-Driver - Added Connection class and relevant tests (#659) * feat: introduce Connection class and enable Pool to create and manage connections * Chore: Python-Spanner-Driver | Spannerlib Wrapper | Added Execute, ExecuteBatch and WriteMutation methods and relevant tests... (#660) * feat: Introduce `Rows` class and add `execute`, `execute_batch`, and `write_mutations` methods to `Connection`. * feat: Add SQL execution, batch DML, and mutation writing methods to Connection and expose Rows object. * Chore: Python-Spanner-Driver - Added Rows class, its methods and relevant tests... (#661) * test: add system tests for query, batch DML, and mutation operations, including emulator setup. * feat: Add `next()`, `metadata()`, `result_set_stats()`, and `update_count()` methods to the `Rows` class for fetching data and statistics, including unit tests. * test: Add system tests for `Rows` class covering metadata, stats, update count, and row iteration. * Chore: Python-Spanner-Driver - Added transaction functions in Connection class and relevant tests... (#662) * feat: Add transaction management with `begin_transaction`, `commit`, and `rollback` methods and their respective tests. * feat: add system and unit tests for transaction mutation writes, including commit and rollback scenarios. * feat: `update_count` returns -1 instead of 0 when row count stats are unavailable and updates the corresponding test. * refactor: remove direct Pool argument from Rows constructor and access via Connection. * feat: Add `IF NOT EXISTS` to `CREATE TABLE` and `IF EXISTS` to `DROP TABLE` statements, removing explicit exception handling. * feat: `write_mutations` now returns `None` for buffered mutations, updating its return type and related tests. * Update spannerlib/wrappers/spannerlib-python/spannerlib-python/google/cloud/spannerlib/internal/message.py Co-authored-by: Knut Olav Løite <koloite@gmail.com> * feat: Remove Python 3.8 fallback for `importlib.resources` and few docstring update * feat: Enhance SpannerLibError messages to include gRPC status names and add corresponding tests. * test: update SpannerLibError repr test message and code values --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Knut Olav Løite <koloite@gmail.com>

…and remove `importlib_resources` dependency.

…king changes.

…_DEPENDENCIES` and `mock`/`asyncmock` from `UNIT_TEST_STANDARD_DEPENDENCIES`.

bhatt4982 requested a review from a team as a code owner December 1, 2025 11:11

gemini-code-assist bot reviewed Dec 1, 2025

View reviewed changes

bhatt4982 force-pushed the psd-01-setup branch from 2035e5d to 319714a Compare December 1, 2025 11:35

gemini-code-assist bot reviewed Dec 2, 2025

View reviewed changes

bhatt4982 and others added 17 commits December 3, 2025 05:20

chore: Create setup for SpannerLib-Python project

e8e0047

refactor: rename nox session 'format_code' to 'format'

a52b1ae

build: update default nox test path from unit to system for system te…

bd7a7bd

…sts.

style: reformat conditional assignment for test paths in noxfile.py

3de9c3c

feat: Add environment variable check for system tests and reorder pac…

bb7d907

…kage installation after other dependencies.

docs: generalize version in README examples and fix: improve build sc…

fad1158

…ript robustness with `set -e`.

chore: increase code coverage failure threshold to 80%

bb7afc3

Update spannerlib/wrappers/spannerlib-python/spannerlib-python/tests/…

8aa5d5a

…unit/test_placeholder.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

chore: remove absolute_import from system test placeholder.

739443e

refactor: remove trailing whitespace from TARGET_WRAPPER_DIR assignme…

e425af1

…nt in build script

docs: Remove trailing whitespace from tar command in README.

e7804e4

fix: skip build_spannerlib session on Windows.

9f28d7e

Update README.md to use wildcard * for whl name

d76e719

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update build-shared-lib.sh to remove dev env comment

b1c7f2e

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update noxfile.py to add more python version test support

4afafd1

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

chore: Remove unused Python version definitions from noxfile and setu…

32daa8a

…p.py.

style: Reformat Python version lists and set flake8 max line length t…

47ffbaa

…o 80.

bhatt4982 force-pushed the psd-01-setup branch from 65e3a36 to 47ffbaa Compare December 3, 2025 05:21

fix: update README tar command to use wildcard for version

5498bd3

olavloite previously approved these changes Dec 3, 2025

View reviewed changes

bhatt4982 changed the title ~~Chore: Python-Spanner-Driver - Project Setup~~ Chore: Python-Spanner-Driver | Spannerlib Wrapper | Project Setup Dec 3, 2025

bhatt4982 dismissed olavloite’s stale review via 45fb2f2 December 4, 2025 14:22

bhatt4982 added 4 commits December 4, 2025 14:50

feat: Add project README, update Python test matrix to include 3.14, …

632bac1

…and remove `importlib_resources` dependency.

chore: Remove sample requirements.txt.

adad7dd

docs: add notice about internal library status and potential for brea…

23da14a

…king changes.

Remove redundant dependencies - google-cloud-spanner from `STANDARD…

6a3785c

…_DEPENDENCIES` and `mock`/`asyncmock` from `UNIT_TEST_STANDARD_DEPENDENCIES`.

olavloite approved these changes Dec 4, 2025

View reviewed changes

bhatt4982 merged commit aac54e0 into main Dec 4, 2025
35 checks passed

bhatt4982 deleted the psd-01-setup branch December 4, 2025 16:39

Chore: Python-Spanner-Driver | Spannerlib Wrapper | Project Setup #656

Chore: Python-Spanner-Driver | Spannerlib Wrapper | Project Setup #656

Conversation

bhatt4982 commented Dec 1, 2025

Uh oh!

gemini-code-assist bot commented Dec 1, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bhatt4982 commented Dec 2, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bhatt4982 commented Dec 2, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

olavloite left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants