feat: Add missing semicolon to use statement of superClass#6350
Merged
bshaffer merged 2 commits intogoogleapis:mainfrom Jun 4, 2025
Merged
feat: Add missing semicolon to use statement of superClass#6350bshaffer merged 2 commits intogoogleapis:mainfrom
bshaffer merged 2 commits intogoogleapis:mainfrom
Conversation
razvanphp
force-pushed
the
fix-superclass-use
branch
from
b3a11ad to
7d356c9
Compare
Contributor
Author
|
@bshaffer please also merge this one, it's a no-brainer, this is a bug. |
bshaffer
approved these changes
Jun 4, 2025
Contributor
|
Wow that's strange, as we have a test which verifies all files generated are valid PHP. I don't know how a bug like this could be avoiding getting caught. I'll look into it, but in the meantime thanks for finding this!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, generated classes are invalid PHP files.