Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Feb 7, 2020

Thanks to @devbww for the suggestion.


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files          88       88           
  Lines        4059     4059           
=======================================
  Hits         3887     3887           
  Misses        172      172
Impacted Files Coverage Δ
google/cloud/internal/future_impl.h 91.39% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946b6d3...1986d8a. Read the comment docs.

@coryan coryan merged commit d96ba55 into googleapis:master Feb 7, 2020
@coryan coryan deleted the rename-extract-cancellation-callback branch February 7, 2020 18:33
coryan added a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
coryan added a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
coryan added a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants