Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

drop executable requirement for INTEGRATION_TEST_CONFIG#1099

Merged
mr-salty merged 1 commit intogoogleapis:masterfrom
mr-salty:nox
Nov 21, 2019
Merged

drop executable requirement for INTEGRATION_TEST_CONFIG#1099
mr-salty merged 1 commit intogoogleapis:masterfrom
mr-salty:nox

Conversation

@mr-salty
Copy link
Copy Markdown
Contributor

@mr-salty mr-salty commented Nov 21, 2019

we only source that script so it doesn't need to be executable, only
readable.


This change is Reviewable

@mr-salty mr-salty requested a review from devjgm November 21, 2019 18:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 21, 2019
we only `source` that script so it doesn't need to be executable, only
readable.
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2019

Codecov Report

Merging #1099 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
- Coverage   92.99%   92.83%   -0.16%     
==========================================
  Files         164      164              
  Lines       12151    12149       -2     
==========================================
- Hits        11300    11279      -21     
- Misses        851      870      +19
Impacted Files Coverage Δ
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 69.9% <0%> (-4.16%) ⬇️
google/cloud/spanner/internal/spanner_stub.cc 68.13% <0%> (-1.1%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 82.45% <0%> (-0.88%) ⬇️
google/cloud/spanner/value.h 92.7% <0%> (-0.11%) ⬇️
google/cloud/spanner/instance_admin_connection.h
google/cloud/spanner/database_admin_connection.h 100% <0%> (ø)
google/cloud/spanner/samples/samples.cc 77.85% <0%> (+0.19%) ⬆️
google/cloud/spanner/internal/polling_loop.h 94.59% <0%> (+2.7%) ⬆️
google/cloud/spanner/internal/retry_loop.h 100% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0945dec...e38a8fc. Read the comment docs.

@mr-salty mr-salty merged commit 9876b58 into googleapis:master Nov 21, 2019
@mr-salty mr-salty deleted the nox branch November 21, 2019 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants