This repository was archived by the owner on Dec 8, 2021. It is now read-only.
cleanup: remove clutter from some samples#1231
Merged
coryan merged 1 commit intogoogleapis:masterfrom Feb 1, 2020
coryan:cleanup-samples
Merged
cleanup: remove clutter from some samples#1231coryan merged 1 commit intogoogleapis:masterfrom coryan:cleanup-samples
coryan merged 1 commit intogoogleapis:masterfrom
coryan:cleanup-samples
Conversation
When possible use single-line `if(..) throw..` to handler errors, and avoid introducing `StatusOr` unless we really use it.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1231 +/- ##
========================================
+ Coverage 94.8% 94.9% +0.1%
========================================
Files 185 185
Lines 13851 13822 -29
========================================
- Hits 13131 13118 -13
+ Misses 720 704 -16
Continue to review full report at Codecov.
|
devjgm
approved these changes
Feb 1, 2020
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…p-spanner#1231) When possible use single-line `if(..) throw..` to handler errors, and avoid introducing `StatusOr` unless we really use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When possible use single-line
if(..) throw..to handler errors, andavoid introducing
StatusOrunless we really use it.This change is