Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

chore: more header cleanup for enabling clang-tidy#1236

Merged
devjgm merged 1 commit intogoogleapis:masterfrom
devjgm:header-cleanup
Feb 4, 2020
Merged

chore: more header cleanup for enabling clang-tidy#1236
devjgm merged 1 commit intogoogleapis:masterfrom
devjgm:header-cleanup

Conversation

@devjgm
Copy link
Copy Markdown
Contributor

@devjgm devjgm commented Feb 3, 2020

This change is Reviewable

@devjgm devjgm requested a review from coryan February 3, 2020 23:45
@devjgm
Copy link
Copy Markdown
Contributor Author

devjgm commented Feb 3, 2020

Related to #355

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2020

Codecov Report

Merging #1236 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1236      +/-   ##
==========================================
- Coverage   94.93%   94.91%   -0.03%     
==========================================
  Files         184      183       -1     
  Lines       13824    13825       +1     
==========================================
- Hits        13124    13122       -2     
- Misses        700      703       +3
Impacted Files Coverage Δ
...gle/cloud/spanner/internal/range_from_pagination.h 89.58% <ø> (ø) ⬆️
google/cloud/spanner/mutations.h 100% <100%> (ø) ⬆️
google/cloud/spanner/testing/matchers.h 60.86% <100%> (ø) ⬆️
google/cloud/spanner/internal/polling_loop.h 91.89% <0%> (-2.71%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 81.57% <0%> (-1.76%) ⬇️
...anner/integration_tests/client_integration_test.cc 98.47% <0%> (-0.01%) ⬇️
google/cloud/spanner/database_admin_connection.h
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 92.37% <0%> (ø) ⬆️
google/cloud/spanner/value.h 92.9% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa17...a1f227a. Read the comment docs.

@devjgm devjgm requested a review from devbww February 4, 2020 01:36
@devjgm devjgm merged commit 8e1f95c into googleapis:master Feb 4, 2020
@devjgm devjgm deleted the header-cleanup branch February 4, 2020 02:48
devjgm added a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants