This repository was archived by the owner on Dec 8, 2021. It is now read-only.
chore: disable warning in test file to simplify code#1264
Merged
devjgm merged 1 commit intogoogleapis:masterfrom Feb 13, 2020
Merged
chore: disable warning in test file to simplify code#1264devjgm merged 1 commit intogoogleapis:masterfrom
devjgm merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1264 +/- ##
=========================================
Coverage ? 94.82%
=========================================
Files ? 184
Lines ? 13810
Branches ? 0
=========================================
Hits ? 13096
Misses ? 714
Partials ? 0
Continue to review full report at Codecov.
|
Disables -Wmissing-field-initializers in one unit test file to improve the readability of our test code. Note: This flag is enabled by -Wextra. More details in the comment in the code.
coryan
approved these changes
Feb 13, 2020
Contributor
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…le-cloud-cpp-spanner#1264) Disables -Wmissing-field-initializers in one unit test file to improve the readability of our test code. Note: This flag is enabled by -Wextra. More details in the comment in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables -Wmissing-field-initializers in one unit test file to improve
the readability of our test code. Note: This flag is enabled by -Wextra.
More details in the comment in the code.
This change is