This repository was archived by the owner on Dec 8, 2021. It is now read-only.
chore: adds spanner-integration-tests labels#1490
Merged
devjgm merged 1 commit intogoogleapis:masterfrom May 6, 2020
Merged
Conversation
This label will be used in `-cpp`. This PR also removes a loop in cmake that appears to be dead code.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 95.57% 95.59% +0.01%
==========================================
Files 194 192 -2
Lines 15925 15924 -1
==========================================
+ Hits 15220 15222 +2
+ Misses 705 702 -3
Continue to review full report at Codecov.
|
coryan
approved these changes
May 5, 2020
Contributor
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @devbww, @mr-salty, and @scotthart)
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…-cpp-spanner#1490) This label will be used in `-cpp`. This PR also removes a loop in cmake that appears to be dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This label will be used in
-cpp. This PR also removes a loop in cmakethat appears to be dead code.
This change is